netdev - RE: [net-next 3/8] i40e: driver ethtool core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <FC41C24E35F18A40888AACA1A36F3E4168533F93@FMSMSX102.amr.corp.intel.com>
Date:	Thu, 20 Jun 2013 20:52:46 +0000
From:	"Nelson, Shannon" <shannon.nelson@...el.com>
To:	Stephen Hemminger <stephen@...workplumber.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>
Subject: RE: [net-next 3/8] i40e: driver ethtool core

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@...workplumber.org]
> Sent: Wednesday, June 19, 2013 11:38 AM
> 
> On Thu, 13 Jun 2013 20:55:17 -0700
> Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
> 
> > +static const struct i40e_stats i40e_gstrings_net_stats[] = {
> > +	I40E_NETDEV_STAT(rx_packets),
> > +	I40E_NETDEV_STAT(tx_packets),
> > +	I40E_NETDEV_STAT(rx_bytes),
> > +	I40E_NETDEV_STAT(tx_bytes),
> > +	I40E_NETDEV_STAT(rx_errors),
> > +	I40E_NETDEV_STAT(tx_errors),
> > +	I40E_NETDEV_STAT(rx_dropped),
> > +	I40E_NETDEV_STAT(tx_dropped),
> > +	I40E_NETDEV_STAT(multicast),
> > +	I40E_NETDEV_STAT(collisions),
> > +	I40E_NETDEV_STAT(rx_length_errors),
> > +	I40E_NETDEV_STAT(rx_over_errors),
> > +	I40E_NETDEV_STAT(rx_crc_errors),
> > +	I40E_NETDEV_STAT(rx_frame_errors),
> > +	I40E_NETDEV_STAT(rx_fifo_errors),
> > +	I40E_NETDEV_STAT(tx_aborted_errors),
> > +	I40E_NETDEV_STAT(tx_carrier_errors),
> > +	I40E_NETDEV_STAT(tx_fifo_errors),
> > +	I40E_NETDEV_STAT(tx_heartbeat_errors),
> > +	I40E_NETDEV_STAT(tx_window_errors),
> > +	I40E_NETDEV_STAT(rx_compressed),
> > +	I40E_NETDEV_STAT(tx_compressed),
> > +}
> 
> Why duplicate network device stats in ethtool stats?

Because the NETDEV_STATs are essentially a subset of the PF_STATs - see my answer to Ben for more details.

We'll try to add a little more commentary here to make it more clear.

sln

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html