netdev - Re: [PATCH net-next 01/11] net/mlx4_en: Suppress page allocation failure warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371763689.3252.419.camel@edumazet-glaptop>
Date:	Thu, 20 Jun 2013 14:28:09 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Amir Vadai <amirv@...lanox.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Jack Morgenstein <jackm@....mellanox.com>
Subject: Re: [PATCH net-next 01/11] net/mlx4_en: Suppress page allocation
 failure warnings

On Thu, 2013-06-20 at 22:40 +0300, Amir Vadai wrote:
> From: Yevgeny Petrilin <yevgenyp@...lanox.com>
> 
> When system is low on resources, those warnings hang the host.
> 
> Signed-off-by: Yevgeny Petrilin <yevgenyp@...lanox.com>
> Signed-off-by: Jack Morgenstein <jackm@....mellanox.com>
> Signed-off-by: Amir Vadai <amirv@...lanox.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/en_rx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> index 9c57581..2b564ac 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> @@ -57,8 +57,8 @@ static int mlx4_en_alloc_frags(struct mlx4_en_priv *priv,
>  	for (i = 0; i < priv->num_frags; i++) {
>  		frag_info = &priv->frag_info[i];
>  		if (ring_alloc[i].offset == frag_info->last_offset) {
> -			page = alloc_pages(GFP_ATOMIC | __GFP_COMP,
> -					MLX4_EN_ALLOC_ORDER);
> +			page = alloc_pages(GFP_ATOMIC | __GFP_COMP |
> +					   __GFP_NOWARN, MLX4_EN_ALLOC_ORDER);
>  			if (!page)
>  				goto out;
>  			dma = dma_map_page(priv->ddev, page, 0,


Thats IMHO a lazy patch...

What about mlx4_en_init_allocator() ?

I think I did a patch doing fallback to order-1 and order-0 allocations




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html