netdev - Re: [PATCH net-next] htb: refactor struct htb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130619.230742.1951790912113794085.davem@davemloft.net>
Date:	Wed, 19 Jun 2013 23:07:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, therbert@...gle.com
Subject: Re: [PATCH net-next] htb: refactor struct htb_sched fields for
 performance

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 15 Jun 2013 03:30:10 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> htb_sched structures are big, and source of false sharing on SMP.
> 
> Every time a packet is queued or dequeue, many cache lines must be
> touched because structures are not lay out properly.
> 
> By carefully splitting htb_sched in two parts, and define sub structures
> to increase data locality, we can improve performance dramatically on
> SMP.
> 
> New htb_prio structure can also be used in htb_class to increase data
> locality.
> 
> I got 26 % performance increase on a 24 threads machine, with 200
> concurrent netperf in TCP_RR mode, using a HTB hierarchy of 4 classes.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html