netdev - Re: [PATCH 6/6] alx: fix ethtool support code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1371847569.8936.4.camel@jlt4.sipsolutions.net>
Date:	Fri, 21 Jun 2013 22:46:09 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 6/6] alx: fix ethtool support code


> > +	u32 supported = SUPPORTED_10baseT_Half |
> > +			SUPPORTED_10baseT_Full |
> > +			SUPPORTED_100baseT_Half |
> > +			SUPPORTED_100baseT_Full;
> > +
> > +	if (alx_hw_giga(hw))
> > +		supported |= SUPPORTED_1000baseT_Full;

> >  	if (ecmd->autoneg == AUTONEG_ENABLE) {
> > -		if (ecmd->advertising & ADVERTISED_1000baseT_Half)
> > +		if (ecmd->advertising & ~alx_get_supported_speeds(hw))
> [...]
> 
> This means that Pause/Asym_Pause advertising can't be directly
> controlled.  

True.

> It's a pain to implement that properly, though, so I
> suppose this can be deferred.

I have no idea how I would do it with this chip. I have no support from
the manufacturer other than their driver, and to be honest I don't have
a huge interest in adding these features, I have no need for them anyway
since my machine is connected to a gbit/full duplex switch :-)

My main concern was getting a driver into mainline, maybe/hopefully the
Qualcomm folks are interested in adding more features to it.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html