lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 21 Jun 2013 09:40:12 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	JunweiZhang <junwei.zhang@...nd.com>
cc:	wensong@...ux-vs.org, horms@...ge.net.au, netdev@...r.kernel.org,
	lvs-devel@...r.kernel.org,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH 1/2] kernel: remove unnecessary head file


	Hello,

On Fri, 21 Jun 2013, junwei.zhang@...nd.com wrote:

> From: JunweiZhang <junwei.zhang@...nd.com>
> 
> ip_vs.h is not necessary for sysctl_binary.c.
> 
> prepare for the next patch to avoid compile issue.
> 
> Signed-off-by: JunweiZhang <junwei.zhang@...nd.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

	Both patches look good to me:

Reviewed-by: Julian Anastasov <ja@....bg>

	Please use version descriptor in future, for example:

[PATCHv2 ...] ...

> ---
>  kernel/sysctl_binary.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c
> index aea4a9e..b609213 100644
> --- a/kernel/sysctl_binary.c
> +++ b/kernel/sysctl_binary.c
> @@ -3,7 +3,6 @@
>  #include "../fs/xfs/xfs_sysctl.h"
>  #include <linux/sunrpc/debug.h>
>  #include <linux/string.h>
> -#include <net/ip_vs.h>
>  #include <linux/syscalls.h>
>  #include <linux/namei.h>
>  #include <linux/mount.h>
> -- 
> 1.8.1.2

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists