netdev - Re: [net-next,v5,2/3] bridge: only expire the mdb entry when query is received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130621073411.GA24488@gondor.apana.org.au>
Date:	Fri, 21 Jun 2013 15:34:11 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Cong Wang <amwang@...hat.com>
Cc:	Linus Lüssing <linus.luessing@....de>,
	netdev@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	"David S. Miller" <davem@...emloft.net>,
	Adam Baker <linux@...er-net.org.uk>
Subject: Re: [net-next,v5,2/3] bridge: only expire the mdb entry when query
 is received

On Fri, Jun 21, 2013 at 03:31:41PM +0800, Cong Wang wrote:
> On Wed, 2013-06-19 at 12:44 +0800, Herbert Xu wrote:
> > On Tue, Jun 18, 2013 at 02:03:38PM +0200, Linus Lüssing wrote:
> > > Hi Amerigo,
> > > 
> > > I just tested these three patches on top of 3.10-rc6 (thanks for
> > > looking into these issues so far!) but unfortunately I'm still
> > > having problems if there is no querier on the link:
> > > 
> > > We will never discover a multicast listener which sends its
> > > startup MLD reports before being attached to the bridge port.
> > > 
> > > I had reported that issue two months ago to Herbert's patch which
> > > changed the querier default [1].
> > > 
> > > I guess in such a scenario where neither our querier is activated
> > > nor could we detect any querier, then the only safe thing we can
> > > do is to disable the bridge multicast snooping, isn't it?
> > 
> > If we have seen no queries then we should simply flood.  The fact
> > that we don't currently is a bug.
> 
> Something like this?

Close, ideally we should allow for at least one timeout interval
after seeing the first query.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html