lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 21 Jun 2013 13:37:29 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 4/6] alx: separate link speed/duplex fields

On Fri, 2013-06-21 at 00:14 +0200, Johannes Berg wrote:
> As suggested by Ben Hutchings, use separate fields to track
> current link speed and duplex setting.
> 
> Reported-by: Ben Hutchings <ben@...adent.org.uk>
> Signed-off-by: Johannes Berg <johannes@...solutions.net>
> ---
>  drivers/net/ethernet/atheros/alx/ethtool.c |  35 ++------
>  drivers/net/ethernet/atheros/alx/hw.c      | 136 ++++++++++++-----------------
>  drivers/net/ethernet/atheros/alx/hw.h      |  24 ++++-
>  drivers/net/ethernet/atheros/alx/main.c    |  37 ++++----
>  4 files changed, 106 insertions(+), 126 deletions(-)
> 
> diff --git a/drivers/net/ethernet/atheros/alx/ethtool.c b/drivers/net/ethernet/atheros/alx/ethtool.c
> index 50a91d0..2170b61 100644
> --- a/drivers/net/ethernet/atheros/alx/ethtool.c
> +++ b/drivers/net/ethernet/atheros/alx/ethtool.c
> @@ -58,7 +58,8 @@ static int alx_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>  			  SUPPORTED_100baseT_Full |
>  			  SUPPORTED_Autoneg |
>  			  SUPPORTED_TP |
> -			  SUPPORTED_Pause;
> +			  SUPPORTED_Pause |
> +			  SUPPORTED_Asym_Pause;
>  	if (alx_hw_giga(hw))
>  		ecmd->supported |= SUPPORTED_1000baseT_Full;
> 
[...]

This hunk belongs in patch 6.

Otherwise, I think this is fine, but I didn't look too closely.

Ben.

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
                                    A fail-safe circuit will destroy others.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)

Powered by blists - more mailing lists