netdev - Re: [PATCH v2 net-next 5/8] qlcnic: Cleanup of structure qlcnic_hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1371898428.3137.5.camel@joe-AO722>
Date:	Sat, 22 Jun 2013 03:53:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	sony.chacko@...gic.com, shahed.shaikh@...gic.com,
	Dept_NX_Linux_NIC_Driver@...gic.com,
	Pratik Pujar <pratik.pujar@...gic.com>
Subject: Re: [PATCH v2 net-next 5/8] qlcnic: Cleanup of structure
 qlcnic_hardware_context

On Sat, 2013-06-22 at 04:12 -0400, Jitendra Kalsaria wrote:
> From: Pratik Pujar <pratik.pujar@...gic.com>

This isn't really a cleanup.
It's allowing more capabilities.

> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
[]
> @@ -449,7 +449,7 @@ struct qlcnic_hardware_context {
>  	u16 max_pci_func;
>  
>  	u32 capabilities;
> -	u32 capabilities2;
> +	u32 extra_capability[3];

Also, it looks like it's used as a bitfield.

I suggest instead using an array of ulongs and
something like tg3's use of tg3_flag_set|tg3_flag_clear.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html