netdev - Re: [PATCH net-next 01/11] net/mlx4_en: Suppress page allocation failure warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1372000491.3301.25.camel@edumazet-glaptop>
Date:	Sun, 23 Jun 2013 08:14:51 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Amir Vadai <amirv@...lanox.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Jack Morgenstein <jackm@....mellanox.com>
Subject: Re: [PATCH net-next 01/11] net/mlx4_en: Suppress page allocation
 failure warnings

On Sun, 2013-06-23 at 11:46 +0300, Amir Vadai wrote:

> But mlx4_en_alloc_frags() is on the data path, and many warnings there
> when the system is already stressed and without memory is bad.
> Besides the warnings, this error flow is handled, and
> mlx4_en_en_fill_rx_buffers() will handle the ENOMEM.
> 
> > 
> > I think I did a patch doing fallback to order-1 and order-0 allocations
> Current code has, as I said above, a fallback to reduce the rx ring size
> when memory is stressed.

Well, it should not do that, and instead use GFP_KERNEL.

>  Do you suggest to use smaller fragments instead
> (or in addition)?
> Can you send me a link to the patch?
> 

Sure, I'll respin it.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html