netdev - Re: [PATCH v2] ipv6: fix ecmp lookup when oif is specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 23 Jun 2013 18:40:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2] ipv6: fix ecmp lookup when oif is specified

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Fri, 14 Jun 2013 10:32:58 +0200

> There is no reason to skip ECMP lookup when oif is specified, but this implies
> to check oif given by user when selecting another route.
> When the new route does not match oif requirement, we simply keep the initial
> one.
> 
> Spotted-by: dingzhi <zhi.ding@...nd.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

IPV4 routing has elided the multipath lookup when the interface is specified
for nearly two decades.

So two things:

1) A decision that old must have a good reason, and you must do some
   research to figure out exactly what that reason is.

2) If ipv4 is found to be wrong too, we must bring both ipv4 and ipv6
   into the same behavior at the same time.

But I do not want to make this change for another reason, it potentially
breaks things for someone, somewhere.  And I see very miniscule, if any,
value to this new behavior.  The risk far outweighs the gains.

Sorry, I really have to reject this patch for now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html