netdev - Re: [PATCH net-next] net: udp4: move GSO functions to udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1372069539.3301.55.camel@edumazet-glaptop>
Date:	Mon, 24 Jun 2013 03:25:39 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Pravin B Shelar <pshelar@...ira.com>
Subject: Re: [PATCH net-next] net: udp4: move GSO functions to udp_offload

On Mon, 2013-06-24 at 10:51 +0200, Daniel Borkmann wrote:
> On 06/24/2013 10:41 AM, Eric Dumazet wrote:
> >
> > Daniel, the same could be done for GRE, ie moving GSO stuff into
> > net/ipv4/gre_offload.c
> >
> > Tell me if you do not have the time to do this, I will handle it.
> 
> Ok, I can do this today.

Thanks !

Oh well, there is a bug in gre_gso_segment(), we need to fix it before
considering this gre_offload.c separation.

if __skb_linearize() fails, kfree_skb(segs); is not really doing the
right thing.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html