[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <51C82885.8030607@cogentembedded.com>
Date: Mon, 24 Jun 2013 15:07:49 +0400
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: David Miller <davem@...emloft.net>
CC: netdev@...r.kernel.org, nobuhiro.iwamatsu.yj@...esas.com,
linux-sh@...r.kernel.org
Subject: Re: [PATCH 1/2] sh_eth: fix unhandled RFE interrupt
Hello.
On 24-06-2013 11:10, David Miller wrote:
>> EESR.RFE (receive FIFO overflow) interrupt is enabled by the driver on all SoCs
>> and sh_eth_error() handles it but it's not present in any initializer/assignment
>> of the 'eesr_err_check' field of 'struct sh_eth_cpu_data'. This leads to that
>> interrupt not being handled and cleared, and finally to disabling IRQ and the
>> driver being non-functional.
>> Modify DEFAULT_EESR_ERR_CHECK macro and all explicit initializers of the above
>> mentioned field to contain the EESR.RFE bit. Remove useless backslashes from the
>> initializers, while at it.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Applied to 'net'.
Queue it for -stable please, the bug goes back to the very start of
the driver development, it seems...
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists