lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Jun 2013 17:09:21 +0300 From: Or Gerlitz <or.gerlitz@...il.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, Or Gerlitz <ogerlitz@...lanox.com> Subject: Re: [PATCH net-next] mlx4: allow order-0 memory allocations in RX path On Sun, Jun 23, 2013 at 6:17 PM, Eric Dumazet <eric.dumazet@...il.com> wrote: > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > > mlx4 exclusively uses order-2 allocations in RX path, which are > likely to fail under memory pressure. > > We therefore drop frames more than needed. > > This patch tries order-3, order-2, order-1 and finally order-0 > allocations to keep good performance, yet allow allocations if/when > memory gets fragmented. > > By using larger pages, and avoiding unnecessary get_page()/put_page() > on compound pages, this patch improves performance as well, lowering > false sharing on struct page. > > Also use GFP_KERNEL allocations in initialization path, as allocating 12 > MB (390 order-3 pages) can easily fail with GFP_ATOMIC. > > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > Cc: Amir Vadai <amirv@...lanox.com> Eric, this looks brilliant, I am OOO today, so will give it a try on my systems tomorrow and ack, thanks for the good work! Or. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists