netdev - Re: [PATCH crypto] crypto: algboss: fix NULL pointer dereference in cryptomgr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51C858A2.40801@redhat.com>
Date:	Mon, 24 Jun 2013 16:33:06 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Herbert Xu <herbert@...dor.hengli.com.au>
CC:	linux-crypto@...r.kernel.org, linux-sctp@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH crypto] crypto: algboss: fix NULL pointer dereference
 in cryptomgr_probe

On 06/24/2013 03:59 PM, Herbert Xu wrote:
...
> Author: Herbert Xu <herbert@...dor.apana.org.au>
> Date:   Mon Jun 24 21:57:42 2013 +0800
>
>      crypto: algboss - Hold ref count on larval
>
...
>
>      The use of wait_for_completion_interruptible is intentional so that
>      we don't lock up the thread if a bug causes us to never wake up.
>
>      This bug is caused by the helper thread using the larval without
>      holding a reference count on it.  If the helper thread completes
>      after the original thread requesting for help has gone away and
>      destroyed the larval, then we get the crash above.
>
>      So the fix is to hold a reference count on the larval.
>
>      Cc: <stable@...r.kernel.org> # 3.6+
>      Reported-by: Daniel Borkmann <dborkman@...hat.com>
>      Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Tested-by: Daniel Borkmann <dborkman@...hat.com>

This fixes the panic for me with the reproducer I sent off-list.

Thanks Herbert !
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html