netdev - Re: [PATCH v2 2/7] alx: fix 100mbit/full duplex speed translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Jun 2013 12:32:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 2/7] alx: fix 100mbit/full duplex speed translation

On Tue, 2013-06-25 at 20:38 +0200, Johannes Berg wrote:
> 100mbit full duplex is ADVERTISED_100baseT_Half, not
> ADVERTISED_10baseT_Half.

Correct code, bad commit message.

> Signed-off-by: Johannes Berg <johannes@...solutions.net>
> ---
>  drivers/net/ethernet/atheros/alx/hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/atheros/alx/hw.c b/drivers/net/ethernet/atheros/alx/hw.c
> index 220a16a..dc71cfb 100644
> --- a/drivers/net/ethernet/atheros/alx/hw.c
> +++ b/drivers/net/ethernet/atheros/alx/hw.c
> @@ -1134,7 +1134,7 @@ static inline u32 alx_speed_to_ethadv(int speed)
>  	case SPEED_100 + DUPLEX_FULL:
>  		return ADVERTISED_100baseT_Full;
>  	case SPEED_100 + DUPLEX_HALF:
> -		return ADVERTISED_10baseT_Half;
> +		return ADVERTISED_100baseT_Half;
>  	case SPEED_10 + DUPLEX_FULL:
>  		return ADVERTISED_10baseT_Full;
>  	case SPEED_10 + DUPLEX_HALF:



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html