netdev - Re: [PATCHv2 net-next 1/4] macvtap: Convert to using rtnl lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1372192278.3301.120.camel@edumazet-glaptop>
Date:	Tue, 25 Jun 2013 13:31:18 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Vlad Yasevich <vyasevic@...hat.com>
Cc:	netdev@...r.kernel.org, mst@...hat.com, davem@...emloft.net
Subject: Re: [PATCHv2 net-next 1/4] macvtap: Convert to using rtnl lock

On Tue, 2013-06-25 at 16:04 -0400, Vlad Yasevich wrote:
> Macvtap uses a private lock to protect the relationship between
> macvtap_queue and macvlan_dev.  The private lock is not needed
> since the relationship is managed by user via open(), release(),
> and dellink() calls.  dellink() already happens under rtnl, so
> we can safely convert open() and release(), and use it in ioctl()
> as well.
> 
> Suggested by Eric Dumazet.
> 
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>
> ---
>  drivers/net/macvtap.c | 62 +++++++++++++++++++++------------------------------
>  1 file changed, 25 insertions(+), 37 deletions(-)

Looks fine to me, thanks !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html