netdev - RE: [PATCH v2 net-next 5/8] qlcnic: Cleanup of structure qlcnic_hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Jun 2013 05:04:02 +0000
From:	Pratik Pujar <pratik.pujar@...gic.com>
To:	Joe Perches <joe@...ches.com>
CC:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Sony Chacko <sony.chacko@...gic.com>,
	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: RE: [PATCH v2 net-next 5/8] qlcnic: Cleanup of structure
 qlcnic_hardware_context


>-----Original Message-----
>From: Joe Perches [mailto:joe@...ches.com]
>Sent: 24 June 2013 23:49
>To: Pratik Pujar
>Cc: Jitendra Kalsaria; David Miller; netdev; Sony Chacko; Shahed Shaikh; Dept-
>NX Linux NIC Driver
>Subject: Re: [PATCH v2 net-next 5/8] qlcnic: Cleanup of structure
>qlcnic_hardware_context
>
>On Mon, 2013-06-24 at 18:17 +0000, Pratik Pujar wrote:
>> >-----Original Message-----
>> >From: Joe Perches [mailto:joe@...ches.com]
>> >Sent: 22 June 2013 16:24
>> >To: Jitendra Kalsaria
>> >Cc: David Miller; netdev; Sony Chacko; Shahed Shaikh; Dept-NX Linux
>> >NIC Driver; Pratik Pujar
>> >Subject: Re: [PATCH v2 net-next 5/8] qlcnic: Cleanup of structure
>> >qlcnic_hardware_context
>> >
>> >On Sat, 2013-06-22 at 04:12 -0400, Jitendra Kalsaria wrote:
>> >> From: Pratik Pujar <pratik.pujar@...gic.com>
>> >
>> >This isn't really a cleanup.
>> >It's allowing more capabilities.
>>
>> The driver was dealing with extra capabilities but separate variables
>> were used for these. Now instead of using separate variables, clubbed
>> in a single array.
>
>What was 2 is now 3 no?
>

Yes, adapter chip exposes extra capabilities through 3 words. Driver uses only 1, as others are reserved as of now. So array extra_capability[3] is a provision for future use of these extra capabilities. 
I will change the description to structure cleanup + provision for future use of extra capabilities. 

>> >> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
>> >> b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
>> >[]
>> >> @@ -449,7 +449,7 @@ struct qlcnic_hardware_context {
>> >>  	u16 max_pci_func;
>> >>
>> >>  	u32 capabilities;
>> >> -	u32 capabilities2;
>> >> +	u32 extra_capability[3];
>
>

Thanks,
Pratik.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html