netdev - Re: [PATCH net-next] tcp: remove invalid _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130625.024438.272501145166501401.davem@davemloft.net>
Date:	Tue, 25 Jun 2013 02:44:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, hkchu@...gle.com
Subject: Re: [PATCH net-next] tcp: remove invalid __rcu annotation

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 25 Jun 2013 01:21:06 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> struct tcp_fastopen_context has a field named tfm, which is a pointer
> to a crypto_cipher structure.
> 
> It currently has a __rcu annotation, which is not needed at all.
> 
> tcp_fastopen_ctx is the pointer fetched by rcu_dereference(), but once
> we have a pointer to current tcp_fastopen_context, we do not use/need
> rcu_dereference() to access tfm.
> 
> This fixes a lot of sparse errors like the following :
> 
> net/ipv4/tcp_fastopen.c:21:31: warning: incorrect type in argument 1 (different address spaces)
> net/ipv4/tcp_fastopen.c:21:31:    expected struct crypto_cipher *tfm
> net/ipv4/tcp_fastopen.c:21:31:    got struct crypto_cipher [noderef] <asn:4>*tfm
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html