netdev - Re: [PATCH] net/tg3: Avoid delay during MMIO access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130625.170125.60596231117979470.davem@davemloft.net>
Date:	Tue, 25 Jun 2013 17:01:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shangw@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, mcarlson@...adcom.com,
	benh@...nel.crashing.org
Subject: Re: [PATCH] net/tg3: Avoid delay during MMIO access

From: Gavin Shan <shangw@...ux.vnet.ibm.com>
Date: Tue, 25 Jun 2013 15:24:32 +0800

> When the EEH error is the result of a fenced host bridge, MMIO accesses
> can be very slow (milliseconds) to timeout and return all 1's,
> thus causing the driver various timeout loops to take way too long and
> trigger soft-lockup warnings (in addition to taking minutes to recover).
> 
> It might be worthwhile to check if for any of these cases, ffffffff is
> a valid possible value, and if not, bail early since that means the HW
> is either gone or isolated. In the meantime, checking that the PCI channel
> is offline would be workaround of the problem.
> 
> Cc: <stable@...r.kernel.org> # v3.0+
> Signed-off-by: Gavin Shan <shangw@...ux.vnet.ibm.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html