netdev - Re: [RFC] about "net: orphan frags on receive" insanity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Jun 2013 22:22:02 +0300
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [RFC] about "net: orphan frags on receive" insanity

On Wed, Jun 26, 2013 at 12:09:24PM -0700, Eric Dumazet wrote:
> On Wed, 2013-06-26 at 21:56 +0300, Michael S. Tsirkin wrote:
> 
> > Well we don't want to duplicate the whole RX path
> > to special-case that, right?
> 
> 
> Whats wrong using a helper ?
> 
> I_Should_cleanup_things(skb)
> {
> 	... // cleanup for these special users trying to reenter stack
> 
> 	netif_rx(skb);
> }
> 

The point is we don't know the final destination of the packet
until it's going through the stack.

We don't want to trigger a copy for all data we get from tun:
we only want to do this if the data has a chance to get
queued somewhere indefinitely.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html