netdev - Re: [PATCH] loopback: set pkt_type to PACKET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130626.152930.1401552744929449732.davem@davemloft.net>
Date:	Wed, 26 Jun 2013 15:29:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yamahata@...inux.co.jp
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	murphy.mccauley@...il.com, pshelar@...ira.com, jesse@...ira.com,
	dev@...nvswitch.org
Subject: Re: [PATCH] loopback: set pkt_type to PACKET_HOST explicitly

From: Isaku Yamahata <yamahata@...inux.co.jp>
Date: Wed, 26 Jun 2013 18:37:51 +0900

> veth does. vethb-peer in the above example.
> (veth_xmit() -> dev_forward_skb() -> eth_type_trans())
> The destination mac address of arp reply is set to the one of
> vetha (!= vethb-peer). So vethb-peer sets pkt_type to OTHERHOST.
> bridge and gretap doesn't touch skb->pkt_type.

I think the dev_forward_skb() assignment of pkt_type should be done
after the call to eth_type_trans().

That's the whole point, we know we're looping the packet back to a
local device on this host.

I'm not applying this loopback patch, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html