netdev - Re: [Patch net] ipv6,mcast: always hold idev->lock before mca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130627034204.GB18553@order.stressinduktion.org>
Date:	Thu, 27 Jun 2013 05:42:04 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Cong Wang <amwang@...hat.com>
Cc:	netdev@...r.kernel.org, dingtianhong <dingtianhong@...wei.com>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net] ipv6,mcast: always hold idev->lock before mca_lock

On Thu, Jun 27, 2013 at 11:09:44AM +0800, Cong Wang wrote:
> On Thu, 2013-06-27 at 00:58 +0200, Hannes Frederic Sowa wrote:
> > I do confirm that if this last hunk is applied the idev->addr_list
> > traversal
> > is safe.
> > 
> > Please let me know if no one is working on this, I would rebase it
> > then. 
> 
> I will rebase my patch on latest net-next. I am assuming this patch
> looks good to you...

Yes, I am fine with the apporach you took. Perhaps you could describe
why the non-idev-locked call to__ipv6_get_lladdr-call is ok in that place.

Thanks a lot,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html