netdev - Re: [PATCH net-next 1/2] ipv6: introduce per-interface counter for dad-completed ipv6 addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130627220236.GA25037@obelix.rh>
Date:	Thu, 27 Jun 2013 19:02:36 -0300
From:	Flavio Leitner <fbl@...hat.com>
To:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org,
	dlstevens@...ibm.com
Subject: Re: [PATCH net-next 1/2] ipv6: introduce per-interface counter for
 dad-completed ipv6 addresses

On Thu, Jun 27, 2013 at 12:06:56AM +0200, Hannes Frederic Sowa wrote:
> To reduce the number of unnecessary router solicitations, MLDv2 and IGMPv3
> messages we need to track the number of valid (as in non-optimistic,
> no-dad-failed and non-tentative) link-local addresses. Therefore, this
> patch implements a valid_ll_addr_cnt in struct inet6_dev.
> 
> We now only emit router solicitations if the first link-local address
> finishes duplicate address detection.
> 
> The changes for MLDv2 and IGMPv3 are in a follow-up patch.
> 
> While there, also simplify one if statement(one minor nit I made in one
> of my previous patches):
> 
> if (!...)
> 	do();
> else
> 	return;
> 
> <<into>>
> 
> if (...)
> 	return;
> do();
> 
> Cc: Flavio Leitner <fbl@...hat.com>
> Cc: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> Cc: David Stevens <dlstevens@...ibm.com>
> Suggested-by: David Stevens <dlstevens@...ibm.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> ---

Looks good and works here.
thanks,
Acked-by: Flavio Leitner <fbl@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html