netdev - RE: [PATCH net-next 4/8] qlcnic: Add support for PEX DMA method to read memory section of adapter dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B72AC@saturn3.aculab.com>
Date:	Thu, 27 Jun 2013 09:56:17 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Shahed Shaikh" <shahed.shaikh@...gic.com>,
	"Jitendra Kalsaria" <jitendra.kalsaria@...gic.com>,
	"David Miller" <davem@...emloft.net>
Cc:	"netdev" <netdev@...r.kernel.org>,
	"Sony Chacko" <sony.chacko@...gic.com>,
	"Dept-NX Linux NIC Driver" <Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: RE: [PATCH net-next 4/8] qlcnic: Add support for PEX DMA method to read memory section of adapter dump

> > > +	if ((tmpl_hdr->version & 0xffffff) >= 0x20001)
> > > +		ahw->fw_dump.use_pex_dma = true;
> > > +	else
> > > +		ahw->fw_dump.use_pex_dma = false;
> >
> > You know what's wrong with the above....
> 
> Yes. Got it.  Masking is not done properly. It should be
> if ((tmpl_hdr->version & 0xfffff) >= 0x20001)

Try:
	ahw->fw_dump.use_pex_dma = (tmpl_hdr->version & 0xfffff) >= 0x20001;

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html