lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 27 Jun 2013 15:21:53 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	Daniel Mack <zonque@...il.com>
CC:	<netdev@...r.kernel.org>, <davem@...emloft.net>
Subject: Re: [PATCH] drivers: net: cpsw: add newline after MACID log

On 6/27/2013 3:10 PM, Daniel Mack wrote:
> Cosmetic patch to add a newline after logging the device's MACID.
>
> Signed-off-by: Daniel Mack <zonque@...il.com>
> ---
>   drivers/net/ethernet/ti/cpsw.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index d1a769f..e10328d 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -1698,10 +1698,10 @@ static int cpsw_probe(struct platform_device *pdev)
>   
>   	if (is_valid_ether_addr(data->slave_data[0].mac_addr)) {
>   		memcpy(priv->mac_addr, data->slave_data[0].mac_addr, ETH_ALEN);
> -		pr_info("Detected MACID = %pM", priv->mac_addr);
> +		pr_info("Detected MACID = %pM\n", priv->mac_addr);
>   	} else {
>   		eth_random_addr(priv->mac_addr);
> -		pr_info("Random MACID = %pM", priv->mac_addr);
> +		pr_info("Random MACID = %pM\n", priv->mac_addr);
>   	}
>   
>   	memcpy(ndev->dev_addr, priv->mac_addr, ETH_ALEN);
Acked-by: Mugunthan V  N <mugunthanvnm@...com>

Regards
Mugunthan V N
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ