netdev - Re: [PATCH v2 2/3] pch_gbe: convert pr_* to netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1372343639.2060.6.camel@joe-AO722>
Date:	Thu, 27 Jun 2013 07:33:59 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	"David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Darren Hart <dvhart@...ux.intel.com>
Subject: Re: [PATCH v2 2/3] pch_gbe: convert pr_* to netdev_*

On Thu, 2013-06-27 at 12:23 +0300, Andy Shevchenko wrote:
> We may use nice macros to prefix our messages with proper device name.
[]
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
[]
> @@ -573,7 +581,7 @@ u16 pch_gbe_mac_ctrl_miim(struct pch_gbe_hw *hw, u32 addr, u32 dir, u32 reg,
>  	}
>  	spin_unlock_irqrestore(&hw->miim_lock, flags);
>  
> -	pr_debug("PHY %s: reg=%d, data=0x%04X\n",
> +	netdev_dbg(adapter->netdev, "PHY %s: reg=%d, data=0x%04X\n",
>  		 dir == PCH_GBE_MIIM_OPER_READ ? "READ" : "WRITE", reg,
>  		 dir == PCH_GBE_MIIM_OPER_READ ? data_out : data);

Hi Andy.

Please make sure to realign the additional
arguments on subsequent lines to the open
parenthesis.

(there are several of these)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html