lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Jun 2013 22:51:16 -0700 (PDT) From: David Miller <davem@...emloft.net> To: nikolay@...hat.com Cc: netdev@...r.kernel.org, andy@...yhouse.net, fubar@...ibm.com Subject: Re: [PATCH net-next 0/3] bonding: struct bonding cleanup and MAC set fixes From: Nikolay Aleksandrov <nikolay@...hat.com> Date: Wed, 26 Jun 2013 17:13:36 +0200 > This patchset removes some unnecessary struct bonding members. It also > fixes MAC setting inconsistencies (i.e. if a bond's MAC is set after > creation but prior to enslaving, it is lost and the first slave's MAC is > cloned again). Before these patches the only way to keep a user-defined MAC > is either to set it after enslaving or to create the bond with that MAC. > Patch 01 - removes setup_by_slave member > Patch 02 - removes dev_addr_from_first member and does the MAC fixing > Patch 03 - introduces the use of NET_ADDR_STOLEN when a MAC is cloned These cleanups seem pretty reasonabl, all applied. And yes I agree that those 3 pr_debug()'s in bond_set_dev_addr() should be condensed into just one. Feel free to send a patch which does that. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists