netdev - Re: [PATCH] net: stmmac: fixed operator typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51CD88B8.6050209@st.com>
Date:	Fri, 28 Jun 2013 14:59:36 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Byungho An <bh74.an@...sung.com>
Cc:	netdev@...r.kernel.org,
	'김국진' <kgene.kim@...sung.com>,
	davem@...emloft.net, cpgs@...sung.com
Subject: Re: [PATCH] net: stmmac: fixed operator typo

On 6/28/2013 9:35 AM, Byungho An wrote:
> 
> This patch fixed operator typo from & to ==.
> Due to incorrect operator, the result is incorrect.
> 
> Signed-off-by: Byungho An <bh74.an@...sung.com>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |   22 +++++++++++++--------
>   1 file changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index c1ad5f4..f088633 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -788,13 +788,13 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv)
>   	int interface = priv->plat->interface;
>   
>   	if (priv->dma_cap.pcs) {
> -		if ((interface & PHY_INTERFACE_MODE_RGMII) ||
> -		    (interface & PHY_INTERFACE_MODE_RGMII_ID) ||
> -		    (interface & PHY_INTERFACE_MODE_RGMII_RXID) ||
> -		    (interface & PHY_INTERFACE_MODE_RGMII_TXID)) {
> +		if ((interface == PHY_INTERFACE_MODE_RGMII) ||
> +		    (interface == PHY_INTERFACE_MODE_RGMII_ID) ||
> +		    (interface == PHY_INTERFACE_MODE_RGMII_RXID) ||
> +		    (interface == PHY_INTERFACE_MODE_RGMII_TXID)) {
>   			pr_debug("STMMAC: PCS RGMII support enable\n");
>   			priv->pcs = STMMAC_PCS_RGMII;
> -		} else if (interface & PHY_INTERFACE_MODE_SGMII) {
> +		} else if (interface == PHY_INTERFACE_MODE_SGMII) {
>   			pr_debug("STMMAC: PCS SGMII support enable\n");
>   			priv->pcs = STMMAC_PCS_SGMII;
>   		}
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html