netdev - Re: [PATCH net-next 2/2] ipv6: resend MLD report if a link-local address completes DAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130628135143.GE15799@order.stressinduktion.org>
Date:	Fri, 28 Jun 2013 15:51:43 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org,
	dlstevens@...ibm.com
Subject: Re: [PATCH net-next 2/2] ipv6: resend MLD report if a link-local address completes DAD

On Thu, Jun 27, 2013 at 07:04:48PM -0300, Flavio Leitner wrote:
> On Thu, Jun 27, 2013 at 12:07:01AM +0200, Hannes Frederic Sowa wrote:
> > RFC3590/RFC3810 specifies we should resend MLD reports as soon as a
> > valid link-local address is available.
> > 
> > We now use the valid_ll_addr_cnt to check if it is necessary to resend
> > a new report.
> > 
> > Changes since Flavio Leitner's version:
> > a) adapt for valid_ll_addr_cnt
> > b) resend first reports directly in the path and just arm the timer for
> >    mc_qrv-1 resends.
> > 
> > Reported-by: Flavio Leitner <fleitner@...hat.com>
> > Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> > Cc: David Stevens <dlstevens@...ibm.com>
> > Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> > Signed-off-by: Flavio Leitner <fbl@...hat.com>
> > ---
> 
> Looks good as well and fixes the issue I had.
> (my signed-off is there already)

Thanks for the testing and review.

May I ask in what situation you want to increase the dad_transmits? Did they
get dropped as part of spanning tree initialization on a port?

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html