netdev - Re: [PATCH v2] net/hsr: Add support for the High-availability Seamless Redundancy protocol (HSRv0)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130628.211632.1064715548223073397.davem@davemloft.net>
Date:	Fri, 28 Jun 2013 21:16:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	arvid.brodin@...n.com
Cc:	netdev@...r.kernel.org, shemminger@...tta.com, joe@...ches.com,
	jboticario@...il.com, balferreira@...glemail.com
Subject: Re: [PATCH v2] net/hsr: Add support for the High-availability
 Seamless Redundancy protocol (HSRv0)

From: Arvid Brodin <arvid.brodin@...n.com>
Date: Wed, 26 Jun 2013 17:16:11 +0200

> +static int hsr_dev_open(struct net_device *dev)
> +{
> +	struct hsr_priv *hsr_priv;
> +
> +	hsr_priv = netdev_priv(dev);
> +
> +	if (hsr_priv->slave[0])
> +		dev_open(hsr_priv->slave[0]);
> +	if (hsr_priv->slave[1])
> +		dev_open(hsr_priv->slave[1]);
> +
> +	return 0;
> +}

dev_open() can and does fail, you must thus check for error returns, undo any
necessary state, and propagate that error to callers of hsr_dev_open.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html