netdev - Re: [PATCH] net: fec: reset rx mode when do suspend/resume or link status change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130628.212502.382862892673771496.davem@davemloft.net>
Date:	Fri, 28 Jun 2013 21:25:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	festevam@...il.com
Cc:	shawn.guo@...aro.org, B38611@...escale.com, b20596@...escale.com,
	netdev@...r.kernel.org, bhutchings@...arflare.com,
	R49496@...escale.com, stephen@...workplumber.org,
	christoph.muellner@...obroma-systems.com
Subject: Re: [PATCH] net: fec: reset rx mode when do suspend/resume or link
 status change

From: Fabio Estevam <festevam@...il.com>
Date: Thu, 27 Jun 2013 10:21:14 -0300

> On Thu, Jun 27, 2013 at 10:15 AM, Shawn Guo <shawn.guo@...aro.org> wrote:
>> On Thu, Jun 27, 2013 at 01:09:19PM +0800, Fugang Duan wrote:
>>> When do suspend/resume, or plug/unplug network cable, or net watchdog
>>> timeout process, fec_restart reinit the enet group hash table to zero.
>>>
>>> It is not reasonable for this, so re-config the enet group hash table
>>> when these actions happen.
>>>
>>> Signed-off-by: Fugang Duan  <B38611@...escale.com>
>>> ---
>>>  drivers/net/ethernet/freescale/fec_main.c |  153 ++++++++++++++---------------
>>>  1 files changed, 76 insertions(+), 77 deletions(-)
>>
>> A forward declaration of set_multicast_list() can simply save these
>> dramatic diff stat?
> 
> Correct, and this has been already been posted:
> http://patchwork.ozlabs.org/patch/253290/

A new version of that patch needs to be posted, and then this one respun
against it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html