netdev - Re: [PATCH 8/8] alx: remove WoL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130629191248.GA10570@sig21.net>
Date:	Sat, 29 Jun 2013 21:12:48 +0200
From:	Johannes Stezenbach <js@...21.net>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 8/8] alx: remove WoL support

On Sat, Jun 29, 2013 at 07:23:20PM +0200, Johannes Berg wrote:
> Unfortunately, WoL is broken and the system will immediately
> resume after suspending, and I can't seem to figure out why.
> Remove WoL support until the issue can be found.
...
> -#ifdef CONFIG_PM_SLEEP
> -static SIMPLE_DEV_PM_OPS(alx_pm_ops, alx_suspend, alx_resume);
> -#define ALX_PM_OPS      (&alx_pm_ops)
> -#else
> -#define ALX_PM_OPS      NULL
> -#endif
> -
>  static DEFINE_PCI_DEVICE_TABLE(alx_pci_tbl) = {
>  	{ PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8161),
>  	  .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG },
> @@ -1614,9 +1472,7 @@ static struct pci_driver alx_driver = {
>  	.id_table    = alx_pci_tbl,
>  	.probe       = alx_probe,
>  	.remove      = alx_remove,
> -	.shutdown    = alx_shutdown,
>  	.err_handler = &alx_err_handlers,
> -	.driver.pm   = ALX_PM_OPS,
>  };

Not sure but doesn't that mean the driver breaks after suspend?
I think you removed too much, not just WOL support but all pm handling.


Johannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html