netdev - Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL1RGDVgSucpRhyxBZDVeLO+Q+Y7HuPsDjUy6kaFMoL3E8s77g@mail.gmail.com>
Date:	Mon, 1 Jul 2013 14:20:44 -0700
From:	Roland Dreier <roland@...nel.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Or Gerlitz <or.gerlitz@...il.com>,
	Eli Cohen <eli@....mellanox.co.il>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	Eli Cohen <eli@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

On Mon, Jul 1, 2013 at 1:19 PM, Joe Perches <joe@...ches.com> wrote:
> I think these are the groupings.
>
> +enum {
> +       MLX5_MOD_MAIN,
> +       MLX5_MOD_CMDIF,
> +       MLX5_MOD_EQ,
> +       MLX5_MOD_QP,
> +       MLX5_MOD_PGALLOC,
> +       MLX5_MOD_FW,
> +       MLX5_MOD_UAR,
> +       MLX5_MOD_ALLOC,
> +       MLX5_MOD_DEBUG,
> +       MLX5_MOD_HEALTH,
> +       MLX5_MOD_MAD,
> +       MLX5_MOD_MCG,
> +       MLX5_MOD_MR,
> +       MLX5_MOD_PD,
> +       MLX5_MOD_PORT,
> +       MLX5_MOD_SRQ,
> +       MLX5_MOD_CQ,
> +       MLX5_MOD_CMD_DATA, /* print command payload only */
> +       MLX5_CMD_DATA_TIME,
> +};


Right, but then look how they're used.  For example,
drivers/net/ethernet/mellanox/mlx5/core/main.c has:

    MLX5_MOD_DBG_MASK(MLX5_MOD_MAIN);

so MLX5_MOD_MAIN just means messages in main.c, etc.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html