netdev - Re: appletalk induced soft lockup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1372658490.3301.311.camel@edumazet-glaptop>
Date:	Sun, 30 Jun 2013 23:01:30 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Dave Jones <davej@...hat.com>
Cc:	netdev@...r.kernel.org, acme@...stprotocols.net
Subject: Re: appletalk induced soft lockup

On Sun, 2013-06-30 at 19:42 -0400, Dave Jones wrote:
> is atalk even maintained any more ? If not I'll take it out of my testing.
> Arnaldo is listed as its maintainer, but I'm sure he has more interesting things
> to work on these days :)
> 
> 	Dave


Could you try following fix ?

Thanks

diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index ef12839..279a287 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -1638,9 +1638,7 @@ static int atalk_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr
 			sk, size, dev->name);
 
 	size += dev->hard_header_len;
-	release_sock(sk);
 	skb = sock_alloc_send_skb(sk, size, (flags & MSG_DONTWAIT), &err);
-	lock_sock(sk);
 	if (!skb)
 		goto out;
 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html