netdev - Re: [PATCH] Ethtool: Free memory leak in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1372694353.2083.2.camel@bwh-desktop.uk.level5networks.com>
Date:	Mon, 1 Jul 2013 16:59:13 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Yuval Mintz <yuvalmin@...adcom.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH] Ethtool: Free memory leak in do_sprivflags()

On Wed, 2013-06-12 at 14:59 +0300, Yuval Mintz wrote:
> cmdline is allocated for usage in parse_generic_cmdline(), but is not
> released after its final usage.
> 
> Signed-off-by: Yuval Mintz <yuvalmin@...adcom.com>

Applied.

Ben.

> ---
>  ethtool.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ethtool.c b/ethtool.c
> index 8cc10b5..b80494d 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -3521,6 +3521,7 @@ static int do_sprivflags(struct cmd_context *ctx)
>  		cmdline[i].seen_val = &seen_flags;
>  	}
>  	parse_generic_cmdline(ctx, &any_changed, cmdline, strings->len);
> +	free(cmdline);
>  
>  	flags.cmd = ETHTOOL_GPFLAGS;
>  	if (send_ioctl(ctx, &flags)) {

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html