netdev - Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL1RGDXsgo9mHteu5MwqnoULd1jqE_LDZ=YfHMH4J=pRZqeLgQ@mail.gmail.com>
Date:	Mon, 1 Jul 2013 11:03:48 -0700
From:	Roland Dreier <roland@...nel.org>
To:	Or Gerlitz <or.gerlitz@...il.com>
Cc:	Eli Cohen <eli@....mellanox.co.il>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	Eli Cohen <eli@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

In general I don't think overriding the CFLAGS (as you do in the mlx5
Makefiles) is a good idea, and in particular here your -Wall -Werror
break the build, at least for my gcc 4.7.3:

  CC      drivers/infiniband/hw/mlx5/qp.o
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘sq_overhead’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:234:2:
error: case value ‘4671’ not in enumerated type ‘enum ib_qp_type’
[-Werror=switch]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘qp_has_rq’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:334:20:
error: comparison between ‘enum ib_qp_type’ and ‘enum <anonymous>’
[-Werror=enum-compare]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘to_mlx5_st’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:464:2:
error: case value ‘4671’ not in enumerated type ‘enum ib_qp_type’
[-Werror=switch]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘create_kernel_qp’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:613:25:
error: comparison between ‘enum ib_qp_type’ and ‘enum <anonymous>’
[-Werror=enum-compare]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘create_qp_common’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:815:25:
error: comparison between ‘enum ib_qp_type’ and ‘enum <anonymous>’
[-Werror=enum-compare]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘get_cqs’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:975:2:
error: case value ‘4671’ not in enumerated type ‘enum ib_qp_type’
[-Werror=switch]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘ib_qp_type_str’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:1064:2:
error: case value ‘4671’ not in enumerated type ‘enum ib_qp_type’
[-Werror=switch]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘mlx5_ib_create_qp’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:1086:26:
error: comparison between ‘enum ib_qp_type’ and ‘enum <anonymous>’
[-Werror=enum-compare]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:1113:2:
error: case value ‘4671’ not in enumerated type ‘enum ib_qp_type’
[-Werror=switch]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘__mlx5_ib_modify_qp’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:1452:20:
error: comparison between ‘enum ib_qp_type’ and ‘enum <anonymous>’
[-Werror=enum-compare]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘mlx5_ib_modify_qp’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:1615:20:
error: comparison between ‘enum ib_qp_type’ and ‘enum <anonymous>’
[-Werror=enum-compare]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c: In
function ‘mlx5_ib_post_send’:
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:2166:19:
error: comparison between ‘enum ib_wr_opcode’ and ‘enum <anonymous>’
[-Werror=enum-compare]
/home/roland/Src/linux-merge.git/drivers/infiniband/hw/mlx5/qp.c:2165:3:
error: case value ‘4671’ not in enumerated type ‘enum ib_qp_type’
[-Werror=switch]


What is this IB_QPT_REG_UMR stuff anyway?  Shouldn't we strip out all
that from the mlx5 driver until it's available in the core code?
Especially stuff like

/*
 * we do not expose this yet so we use a value out of range */
enum {
        IB_QPT_REG_UMR = IB_QPT_MAX + 0x1234,
};

/* ===> this should be passed to the vergbs layer */
enum {
        IB_WR_SET_PSV = IB_WR_BIND_MW + 10,
        IB_WR_GET_PSV,
        IB_WR_CHECK_PSV,
        IB_WR_RGET_PSV,
        IB_WR_RCHECK_PSV,
        IB_WR_UMR,
};

enum {
        IB_SEND_UMR_UNREG       = IB_SEND_IP_CSUM << 1,
};

enum ib_latency_class {
        IB_LATENCY_CLASS_LOW,
        IB_LATENCY_CLASS_MEDIUM,
        IB_LATENCY_CLASS_HIGH,
        IB_LATENCY_CLASS_FAST_PATH
};
/* <=== this should be passed to the vergbs layer */

looks like it shouldn't be in your submission.  (What are "vergbs" anyway? :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html