netdev - Re: [PATCH net] ipv6: ip6_append_data_mtu did not care about pmtudisc and frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130701182311.GD8937@order.stressinduktion.org>
Date:	Mon, 1 Jul 2013 20:23:11 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	netdev@...r.kernel.org, gaofeng@...fujitsu.com,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net] ipv6: ip6_append_data_mtu did not care about pmtudisc and frag_size

On Mon, Jul 01, 2013 at 08:17:42PM +0200, Hannes Frederic Sowa wrote:
> If the socket had an IPV6_MTU value set, ip6_append_data_mtu lost track
> of this when appending the second frame on a corked socket. This results
> in the following splat:
> 
> [...]
> 
> While there, also check if path mtu discovery is activated for this
> socket. The logic was adapted from ip6_append_data when first writing
> on the corked socket.
> 
> This bug was introduced with commit
> 0c1833797a5a6ec23ea9261d979aa18078720b74 ("ipv6: fix incorrect ipsec
> fragment").
> 
> Cc: Gao feng <gaofeng@...fujitsu.com>
> Cc: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> ---
>  net/ipv6/ip6_output.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

I would love to have additional review for this patch. I am fairly sure that
this patch is correct, but...

Thanks,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html