netdev - Re: [PATCH 03/10] 9pnet: refactor struct p9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51D3029A.8050100@cogentembedded.com>
Date:	Tue, 02 Jul 2013 20:40:58 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Simon Derr <simon.derr@...l.net>
CC:	netdev@...r.kernel.org, ericvh@...il.com
Subject: Re: [PATCH 03/10] 9pnet: refactor struct p9_fcall alloc code

Hello.

On 02-07-2013 17:11, Simon Derr wrote:

> Signed-off-by: Simon Derr <simon.derr@...l.net>
> ---
>   net/9p/client.c |   35 ++++++++++++++++++-----------------
>   1 files changed, 18 insertions(+), 17 deletions(-)

> diff --git a/net/9p/client.c b/net/9p/client.c
> index 47cd7d0..44691b9 100644
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -204,6 +204,17 @@ free_and_return:
>   	return ret;
>   }
>
> +struct p9_fcall *p9_fcall_alloc(int alloc_msize)
> +{
> +	struct p9_fcall *fc;

    Empty line wouldn't hurt here, after declaration.

> +	fc = kmalloc(sizeof(struct p9_fcall) + alloc_msize, GFP_NOFS);
> +	if (!fc)
> +		return NULL;
> +	fc->capacity = alloc_msize;
> +	fc->sdata = (char *) fc + sizeof(struct p9_fcall);
> +	return fc;
> +}
> +
[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html