netdev - Re: [PATCH net v2] ipv6: ip6_append_data_mtu did not care about pmtudisc and frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130702.124514.1701303518493328527.davem@davemloft.net>
Date:	Tue, 02 Jul 2013 12:45:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, gaofeng@...fujitsu.com,
	yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net v2] ipv6: ip6_append_data_mtu did not care about
 pmtudisc and frag_size

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Tue, 2 Jul 2013 08:04:05 +0200

> If the socket had an IPV6_MTU value set, ip6_append_data_mtu lost track
> of this when appending the second frame on a corked socket. This results
> in the following splat:
 ...
> While there, also check if path mtu discovery is activated for this
> socket. The logic was adapted from ip6_append_data when first writing
> on the corked socket.
> 
> This bug was introduced with commit
> 0c1833797a5a6ec23ea9261d979aa18078720b74 ("ipv6: fix incorrect ipsec
> fragment").
> 
> v2:
> a) Replace IPV6_PMTU_DISC_DO with IPV6_PMTUDISC_PROBE.
> b) Don't pass ipv6_pinfo to ip6_append_data_mtu (suggestion by Gao
>    feng, thanks!).
> c) Change mtu to unsigned int, else we get a warning about
>    non-matching types because of the min()-macro type-check.
> 
> Acked-by: Gao feng <gaofeng@...fujitsu.com>
> Cc: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html