netdev - Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZLBfKr6xTeJZO8vD=bkQgBVVCAUTRnLKJ7FONU-Z1=iag@mail.gmail.com>
Date:	Wed, 3 Jul 2013 00:03:36 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Joe Perches <joe@...ches.com>, Roland Dreier <roland@...nel.org>
Cc:	Eli Cohen <eli@....mellanox.co.il>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	Eli Cohen <eli@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Jack Morgenstein <jackm@....mellanox.co.il>
Subject: Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

On Mon, Jul 1, 2013 at 9:03 PM, Joe Perches <joe@...ches.com> wrote:
> On Mon, 2013-07-01 at 10:49 -0700, Roland Dreier wrote:

On Mon, Jul 1, 2013 at 9:03 PM, Joe Perches <joe@...ches.com> wrote:
> On Mon, 2013-07-01 at 10:49 -0700, Roland Dreier wrote:

[...]
>> +struct mlx5_cmd {
>> ...
>> +    struct mlx5_cmd_stats    stats[0x80a];
>> the 0x80a magic number really needs to have a name.

> And that's a pretty big struct too. 2058 array entries. ~100kb
> Does it really need to be that big?

Indeed a bit of biggish, but note there's just one instance of this
arrary per HCA port. For now we will leave this size but make it less
obscure, will be MLX5_CMD_OP_LAST
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html