netdev - Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZ+1JKs-rK3kig64qgahVoYenkCR47JM3f4T6LEfhLqPhQ@mail.gmail.com>
Date:	Wed, 3 Jul 2013 00:36:35 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Roland Dreier <roland@...nel.org>
Cc:	Eli Cohen <eli@....mellanox.co.il>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	Eli Cohen <eli@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Jack Morgenstein <jackm@....mellanox.co.il>
Subject: Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

On Mon, Jul 1, 2013 at 8:49 PM, Roland Dreier <roland@...nel.org> wrote:
> So I'm inclined to apply the mlx5 driver for 3.11, since it's a
> completely new driver.  However, reading through it so far I had the
> following comments, and I'd like these cleanups addressed along with Dave Miller's:

Roland,

Working to have all Dave Miller's comments addressed along with yours
and post V2 later this week, so we will be still on track for a 3.11
merge of the core and IB driver through your tree.


> - The debug mask complexity seems unnecessary now that pr_debug() is
> controllable at runtime with the DYNAMIC_DEBUG stuff.  We should get
> rid of the extra level of indirection.

OK

> - I think the active flag for the health check timer is unnecessary.
> It can just be stopped with del_timer_sync().

Jack was looking on this today and we're not sure, he will send his
reading of the matter tomorrow.

> - Many places use "foo_spl" as a name, and in the Linux kernel
> "foo_lock" would be much more idiomatic and easier to read.

sure, done.

>
> - In:
>
> +struct mlx5_cmd {
> ...
> +    struct mlx5_cmd_stats    stats[0x80a];
>
> the 0x80a magic number really needs to have a name.

done.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html