netdev - Re: [PATCH] core/dev: set pkt_type after eth_type_trans() in dev_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130702.160005.59343488202291094.davem@davemloft.net>
Date:	Tue, 02 Jul 2013 16:00:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yamahata@...inux.co.jp
Cc:	netdev@...r.kernel.org, murphy.mccauley@...il.com,
	jasowang@...hat.com, mst@...hat.com, edumazet@...gle.com,
	kaber@...sh.net, honkiko@...il.com, ramirose@...il.com,
	tparkin@...alix.com, xiyou.wangcong@...il.com, pshelar@...ira.com,
	jesse@...ira.com, dev@...nvswitch.org
Subject: Re: [PATCH] core/dev: set pkt_type after eth_type_trans() in
 dev_forward_skb()

From: Isaku Yamahata <yamahata@...inux.co.jp>
Date: Tue,  2 Jul 2013 20:30:10 +0900

> The dev_forward_skb() assignment of pkt_type should be done
> after the call to eth_type_trans().
> 
> ip-encapsulated packets can be handled by localhost. But skb->pkt_type
> can be PACKET_OTHERHOST when packet comes via veth into ip tunnel device.
> In that case, the packet is dropped by ip_rcv().
> Although this example uses gretap. l2tp-eth also has same issue.
> For l2tp-eth case, add dummy device for ip address and ip l2tp command.
 ...
> Signed-off-by: Isaku Yamahata <yamahata@...inux.co.jp>

Applied, but I had to adjust the patch because in net-next we use
a new helper function (skb_scrub_packet()) to clear things out from
dev_forward_skb().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html