netdev - Re: [PATCH net v2] ip_tunnels: Use skb-len to PMTU check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130701.235654.449447235538486676.davem@davemloft.net>
Date:	Mon, 01 Jul 2013 23:56:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org, timo.teras@....fi
Subject: Re: [PATCH net v2] ip_tunnels: Use skb-len to PMTU check.

From: Pravin B Shelar <pshelar@...ira.com>
Date: Sun, 30 Jun 2013 23:30:32 -0700

> In path mtu check, ip header total length works for gre device
> but not for gre-tap device.  Use skb len which is consistent
> for all tunneling types.  This is old bug in gre.
> This also fixes mtu calculation bug introduced by
> commit c54419321455631079c7d (GRE: Refactor GRE tunneling code).
> 
> Reported-by: Timo Teras <timo.teras@....fi>
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>

Can you please respin this against net-next?  The packet building
flow is significantly different there.

I'll keep this copy around for -stable.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html