netdev - Re: [PATCH net-next] ethtool: make .get_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130702.001625.1799445191829949810.davem@davemloft.net>
Date:	Tue, 02 Jul 2013 00:16:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mschmidt@...hat.com
Cc:	netdev@...r.kernel.org, anirban.chakraborty@...gic.com,
	bhutchings@...arflare.com
Subject: Re: [PATCH net-next] ethtool: make .get_dump_data() harder to
 misuse by drivers

From: Michal Schmidt <mschmidt@...hat.com>
Date: Mon,  1 Jul 2013 17:23:30 +0200

> As the patch "bnx2x: remove zeroing of dump data buffer" showed,
> it is too easy implement .get_dump_data incorrectly in a driver.
> 
> Let's make sure drivers cannot get confused by userspace requesting
> a too big dump.
> 
> Also WARN if the driver sets dump->len to something weird and make
> sure the length reported to userspace is the actual length of data
> copied to userspace.
> 
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html