netdev - Re: [Patch net v2] ipip: fix a regression in ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130702.011343.820354785599717014.davem@davemloft.net>
Date:	Tue, 02 Jul 2013 01:13:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, pshelar@...ira.com
Subject: Re: [Patch net v2] ipip: fix a regression in ioctl

From: Cong Wang <amwang@...hat.com>
Date: Tue,  2 Jul 2013 14:49:34 +0800

> From: Cong Wang <amwang@...hat.com>
> 
> This is a regression introduced by 
> commit fd58156e456d9f68fe0448 (IPIP: Use ip-tunneling code.)
> 
> Similar to GRE tunnel, previously we only check the parameters
> for SIOCADDTUNNEL and SIOCCHGTUNNEL, after that commit, the
> check is moved for all commands.
> 
> So, just check for SIOCADDTUNNEL and SIOCCHGTUNNEL.
> 
> Also, the check for i_key, o_key etc. is suspicious too,
> which did not exist before, reset them before passing
> to ip_tunnel_ioctl().
> 
> Cc: Pravin B Shelar <pshelar@...ira.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Signed-off-by: Cong Wang <amwang@...hat.com>

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html