netdev - Re: [PATCH v1 0/3] extend stmmac DT support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130703.160423.1285164466482391784.davem@davemloft.net>
Date:	Wed, 03 Jul 2013 16:04:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	srinivas.kandagatla@...com
Cc:	netdev@...r.kernel.org, peppe.cavallaro@...com,
	grant.likely@...aro.org, rob.herring@...xeda.com, rob@...dley.net,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/3] extend stmmac DT support.

From: Srinivas KANDAGATLA <srinivas.kandagatla@...com>
Date: Tue,  2 Jul 2013 14:03:39 +0100

> From: Srinivas Kandagatla <srinivas.kandagatla@...com>
> 
> Hi Peppe,
> 
> Thankyou for the comments on RFC patches.
> 
> This patch series adds support to new gmac versions 3.6.10 and 3.710, these
> versions of IP are integrated into ST STiH415/STiH416 SOCs.
> This patchset also adds phy reset capablity to stmmac-mdio driver via DT.
> 
> Changes since RFC:
> 	- re-use existing compatible strings to select right properties.
> 	- clean up reset callback support so that DT is not parsed everytime.

You are going to have to fix up the following build warnings and resubmit:

  CC [M]  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.o
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c: In function ‘stmmac_mdio_reset’:
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c:137:17: warning: unused variable ‘dev’ [-Wunused-variable]
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c: In function ‘stmmac_mdio_register’:
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c:200:17: warning: unused variable ‘dev’ [-Wunused-variable]


Thanks.