netdev - Re: [PATCH] net: sock: fix TCP_SKB_MIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130703.165255.2199744750245012601.davem@davemloft.net>
Date:	Wed, 03 Jul 2013 16:52:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, dborkman@...hat.com, ncardwell@...gle.com
Subject: Re: [PATCH] net: sock: fix TCP_SKB_MIN_TRUESIZE

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 03 Jul 2013 05:02:22 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> commit eea86af6b1e18d ("net: sock: adapt SOCK_MIN_RCVBUF and
> SOCK_MIN_SNDBUF") forgot the sk_buff alignment taken into account
> in __alloc_skb() : skb->truesize = SKB_TRUESIZE(size);
> 
> While above commit fixed the sender issue, the receiver is still
> dropping the second packet (on loopback device), because the receiver
> socket can not really hold two skbs :
> First packet truesize already is above sk_rcvbuf, so even TCP coalescing
> cannot help.
> 
> On a typical 64bit build, each tcp skb truesize is 2304, instead of 2272
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html