netdev - Re: [PATCH V3 2/2] Introduce huawei_cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1372868333.1919.3.camel@bwh-desktop.uk.level5networks.com>
Date:	Wed, 3 Jul 2013 17:18:53 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Enrico Mioso <mrkiko.rs@...il.com>
CC:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH V3 2/2] Introduce huawei_cdc_ncm driver

On Wed, 2013-07-03 at 15:38 +0200, Enrico Mioso wrote:
> This new driver, handles devices that mimic the NCM standard, but using NCM as
> a transport layer to encapsulate other protocols (i.e. AT protocol).
> 
> Signed-off-by: Enrico Mioso <mrkiko.rs@...il.com>

Add a '---' separator here, between the commit message and the list of
changes that doesn't need to go in the commit message.

> V3:
>   - fixed typo in Kconfig (help text)
>
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 287cc62..33cb175 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -246,6 +246,18 @@ config USB_NET_CDC_NCM
>  	    * ST-Ericsson M343 HSPA Mobile Broadband Modem (reference design)
>  	    * Ericsson F5521gw Mobile Broadband Module
>  
> +config USB_NET_HUAWEI_CDC_NCM
> +	tristate "Huawei-style CDC NCM support"
> +	depends on USB_USBNET
> +	default y
> +	select USB_WDM
> +	select USB_NET_CDC_NCM
[...]

The new config symbol should either depend on USB_NET_CDC_NCM (rather
than selecting it), or have no default setting.  It is not correct to
enable it by default just because USB_USBNET is selected.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html