netdev - Re: [PATCH v2 net-next] ipmr: change the prototype of ip_mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130704.142724.1657930430240129696.davem@davemloft.net>
Date:	Thu, 04 Jul 2013 14:27:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ramirose@...il.com
Cc:	netdev@...r.kernel.org, nicolas.dichtel@...nd.com
Subject: Re: [PATCH v2 net-next] ipmr: change the prototype of
 ip_mr_forward().

From: Rami Rosen <ramirose@...il.com>
Date: Fri,  5 Jul 2013 01:15:55 +0300

> @@ -127,7 +127,7 @@ static struct kmem_cache *mrt_cachep __read_mostly;
>  static struct mr_table *ipmr_new_table(struct net *net, u32 id);
>  static void ipmr_free_table(struct mr_table *mrt);
>  
> -static int ip_mr_forward(struct net *net, struct mr_table *mrt,
> +static void ip_mr_forward(struct net *net, struct mr_table *mrt,
>  			 struct sk_buff *skb, struct mfc_cache *cache,
>  			 int local);
>  static int ipmr_cache_report(struct mr_table *mrt,

When you change the column that the openning parenthesis of a function
declaration appears at, you must reindent all of the subsequent lines
of the declaration such that the first character lines up with the first
column after the openning parenthesis.

> @@ -1795,7 +1795,7 @@ static int ipmr_find_vif(struct mr_table *mrt, struct net_device *dev)
>  
>  /* "local" means that we should preserve one skb (for local delivery) */
>  
> -static int ip_mr_forward(struct net *net, struct mr_table *mrt,
> +static void ip_mr_forward(struct net *net, struct mr_table *mrt,
>  			 struct sk_buff *skb, struct mfc_cache *cache,
>  			 int local)

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html