netdev - Re: [PATCH net] sfc: Fix memory leak when discarding scattered packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130705.012958.510964485167451748.davem@davemloft.net>
Date:	Fri, 05 Jul 2013 01:29:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH net] sfc: Fix memory leak when discarding scattered
 packets

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 4 Jul 2013 23:48:46 +0100

> Commit 2768935a4660 ('sfc: reuse pages to avoid DMA mapping/unmapping
> costs') did not fully take account of DMA scattering which was
> introduced immediately before.  If a received packet is invalid and
> must be discarded, we only drop a reference to the first buffer's
> page, but we need to drop a reference for each buffer the packet
> used.
> 
> I think this bug was missed partly because efx_recycle_rx_buffers()
> was not renamed and so no longer does what its name says.  It does not
> change the state of buffers, but only prepares the underlying pages
> for recycling.  Rename it accordingly.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> ---
> This bug fix needs to go into 3.10.y as well.

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html